Project

General

Profile

Bug #9991

ARF Upload fails on first error event if it's client error

Added by Marek Hulán over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Yesterday we found that during arf report uploading from smart proxy to Foreman the process can fail if Foreman does not respond with 200. This can cause proxy to not upload any other report easily, suppose Foreman responds with 404. This can easily happen if you upload one report from client with wrong certificate or you simply remove a host from Foreman. We should not raise exception in such case just log it and continue with other report.

See
https://github.com/OpenSCAP/smart_proxy_openscap/blob/v0.4.0/lib/smart_proxy_openscap/openscap_lib.rb#L120
https://github.com/OpenSCAP/smart_proxy_openscap/blob/v0.4.0/lib/smart_proxy_openscap/openscap_lib.rb#L127

Associated revisions

Revision c9bb35e0 (diff)
Added by Ondřej Pražák about 3 years ago

Fixes #9991 - Exceptions not raised, errors only logged

Revision ce0b2da5
Added by Marek Hulán almost 3 years ago

Merge pull request #16 from xprazak2/upload-exception

Fixes #9991 - Exceptions not raised, errors only logged

History

#1 Updated by Ondřej Pražák about 3 years ago

  • Assignee set to Ondřej Pražák

#2 Updated by Ondřej Pražák about 3 years ago

  • Pull request https://github.com/theforeman/smart_proxy_openscap/pull/16 added
  • Pull request deleted ()

#3 Updated by Marek Hulán almost 3 years ago

  • Status changed from New to Closed
  • Target version set to 0.5.0
  • % Done changed from 0 to 100

Also available in: Atom PDF