Project

General

Profile

Feature #9993

Root password and partition table should be optional when not in build mode

Added by Christine Fouant almost 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Host creation
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

A host should be able to be created without setting a root password or partition table if being created outside of build mode.


Related issues

Related to Foreman - Bug #31239: Can set root password with less than 8 characters on host rebuildNew

Associated revisions

Revision aea52e15 (diff)
Added by Christine Fouant almost 8 years ago

fixes #9993 - Removes root password and partition table reqs unless build mode selected

History

#1 Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2283 added
  • Pull request deleted ()

#2 Updated by Dominic Cleal almost 8 years ago

  • Category set to Host creation
  • Assignee set to Christine Fouant

#3 Updated by Christine Fouant almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal almost 8 years ago

  • Legacy Backlogs Release (now unused) set to 35

#5 Updated by Dominic Cleal over 7 years ago

Why was this changed? Seems strange to me, looks like you actually want an unmanaged host and not a managed host that's !build. (Maybe revert after #10413?)

#6 Updated by Christine Fouant over 7 years ago

It was prerequisite to the Host Unification design feature team. I was following what validate_media? outlines in managed hosts model. The goal is for a user to be able to create a host that may or may not want to use puppet, but still be able to manage puppet, so I don't think the unmanaged host is the solution. Correct me if I'm wrong, but in unmanaged, users don't manage puppet, correct?

#7 Updated by Dominic Cleal over 7 years ago

Christine Fouant wrote:

The goal is for a user to be able to create a host that may or may not want to use puppet, but still be able to manage puppet, so I don't think the unmanaged host is the solution. Correct me if I'm wrong, but in unmanaged, users don't manage puppet, correct?

Yes, that's incorrect, an unmanaged host is typically just for Puppet with no provisioning support.

#8 Updated by Justin Sherrill over 7 years ago

Install media was already checking for 'build?', so i guess that was wrong as well.

There also isn't a way to create an unmanaged host in the UI is there? Granted that may be a separate feature, but we were using the UI to guide us as to how to implement this it may have been what led us astray (as we were following the install media example).

#9 Updated by Justin Sherrill over 7 years ago

err, i guess the validate_media? method is checking for managed as well, but from a user perspective using the UI and trying to make a host with as little information as possible, this seemed to be the 'right' solution. I can see how using managed? would be better.

#10 Updated by Dominic Cleal over 7 years ago

Yeah, I don't think the media check is right either - validation should probably be consistent irrespective of the state of the host, and only dependent on the type.

It's not possible to create an unmanaged host when in unattended mode. We're tracking some of this under #10413 to unify it a bit.

#11 Updated by Lukas Zapletal over 2 years ago

  • Related to Bug #31239: Can set root password with less than 8 characters on host rebuild added

Also available in: Atom PDF