Foreman Maintain

Fixes #20848 - Fix error messages indentation

Fixes #20597 - store the current target version of upgrade

This allows to prevent running one upgrade before finishing another one.
It also fixes an issue, where after updating the packages, one would not
be able to continue with the current upgrade when something goes wrong.

Fixes #20868 - Use correct method 'get_params_for'

Fixes #20641 - clean the upgrade storage on upgrade finish

Fixes #20625 - Add 'upgrade scneario'

• 6.2 -> 6.2.z
• 6.2 -> 6.3
• 6.3 -> 6.3.z

Fixes #20221 - Added log_file_size as config parameter in KB

Merge remote-tracking branch 'origin/master' into upgrade-workflow

Fixes #46 - isc dhcp configuration check

Merge remote-tracking branch 'origin/master' into upgrade-workflow

`upgrade run --phase` instead of `upgrade advanced run`

To improve the usability of the command

Use --target-version option instead of parameter

Clamp doesn't handle positions of parameters very well, unifying
to use options for this as well.

Extract transform_clamp_options

Add commands for executing procedures

Update from review

Newly added config constants for packaging.

Fix rubocop

Simplify the dependency graph

When composing the dependency graph for tsort, use just the collection
it was set to, instead of using resolver to find the classes by label.

Besides simplification, it also preserves the order in which the steps
were added, otherwise, the order was dependent on the Ruby version (and...

Remove the singleton form ObjectCache

The object cache was causing issues when running multiple scenarios in
one run, where the objects from previous step were interfering with the
later scenarios, if the same steps were used in both of them.

Handle migration phase setting when not confirmed

Before this change, the phase was set to new one before the user full
confirmed she wants to proceed with the upgrade, which cause the checks
to be skipped on next run.

Fix intermittent test failures

Advanced run command and tests

Support for run_once procedures and repositories setup

Configure repositories and update packages

Update the satellite upgrade to new code

Rollback support if the upgrade fails soon enough

Support for scenario serialization/deserialization

Extract control flow of upgrades to special file

Don't continue with scenarios when last is not finished

Move sync-plans checks to pre/post migrations

Introduce run_strategy for scenarios

Health-check scenarios are better to run all steps regardless of errors
(:fail_slow strategy), while the migration scenarios should fail as soon
as first failure happens (:fail_fast strategy).

By default, the scenarios are treated as `:fail_fast`.

Add --whitelist option

Allows to mark some steps to be ignored in the results: allows to
continue even when some checks are failing.

Full upgrade scenario

This commit intoroduces more structured upgrade scenario consisting of
this scenarios:

• pre_upgrade_check - non-modifying checks: is the system ready?
• pre_migrations - modifying procedures before source update
• migrations - source update and main migrations...

Retain original objects while Tsorting. TSort create label graph and then convert to object graph

Define order using ruby TSort

1. Introduce 2 metadata: 'before' and 'after'
2. Current order is:
Checks::SyncPlans::WithEnabledStatus
Checks::DiskSpeedMinimal
Checks::SystemRegistration
Checks::ForemanTasks::NotPaused
Checks::ForemanTasks::NotRunning
Checks::ForemanTasks::Invalid::CheckOld...

Fixes #59 - missing error for hammer-config file

Assumeyes option

Tests for preparation steps

Improve reporting on hammer setup and preparation steps

Hammer setup preparation step

RFE #23 - Add new status [WARNING] - Check: is system self registered

RFE #16 - Delete invalid tasks

Fixes #19 - Handled sync plans before & after upgrade

With this commit, below changes included -
1. Two new checks
- Disable sync plans before upgrade
- Enable sync plans after upgrade which are disabled previously.

2. Created directory lib/foreman_maintain/storage in which...

Fixes #44 - Change tag 'basic' to 'default'

Rerun the check after a procedure

When user chooses a procedure, we now re-run the check again to make sure the
issue if resolved. This allows to repeat the check/fix cycle several times:
also the multiple steps for procedures make more sense now.

Decouple more reporter from runner

Before this commit, we required the reporter to call back runner
methods, which complicated the things. Also the multiple-steps select
was not working properly.

After this change, the reporter just returns a decision as result of...

Add tests for tasks paused check and additional procedures

Namespace checks and procedures

Let's organize the stuff a bit better

Fixes #3 - Add option to skip the prompted step

Fixes #18 - introduce configuration file

Done changes for rubocop v0.48.1

Compatiblity with rubocop v0.48.0

1. Disabled: Use %i or %I for an array of symbols
2. Fixed: Use 2 spaces for indentation in a heredoc by using some library(e.g. ActiveSupport's String#strip_heredoc). Created foreman_maintain/core_ext.rb extend String class....

Turn hammer feature into a utils class

After looking more into this, I think the util class is actually better
fit for the hammer case. I've also removed the detection of the
credentials from hammer configuration, as we actually don't need
the credentials by our own.

Make the spinner opt-in, not opt-out

The default spinner caused issues when one needs to interact with the
user (printing additional messages). As it's needed only for long
running actions, it should not be enforced by default.

Set next steps with the assert check

This allows adding more assertions to the check, each adding their own
next steps.

Run confine against classes, not objects

This allows us to have multiple objects of the same procedure in the
system, differing in the constructor parameters. Useful for parametrized
procedures.

Extract metadata DSL to separate namespace

Having the DSL methods directly on the classes caused issues when
needing to query the metadata later.

Add tests for empty args in cli

Allow running checks by label

Fixes #1 - IO operations on disk and file system

1) Removed feature DiskIO(Check is sufficent)
2) rename Concerns::DiskUtility to Utils::Disk
3) Move disk_utlity_concerns logic to Check itself
4) confine hdparm and fio
5) Error log message - verbore and descriptive...

Fix loading of features from confine

With some ordering, the features could get tried to be detected twice.

Add scaffold for definitions tests

tests for health commands

Move lib-specific tests to separate directory

CLI basic structure

Refactor the choice of next steps

Refactor: make autodetect opt-out

Ability to define precedures

Unify test definitions

Follow present_service/missing_service convention across the definitions.

Unify finder and detector

The detector now can do both detection and filtering

Refactor

Rename feature_name to more generic label

Tests for runner and reporter

Ability to define and filter checks

Add first tests