Actions
Bug #13217
closedDiscovery Rules order by name, not priority
Status:
Closed
Priority:
Urgent
Assignee:
Category:
Image
Target version:
Difficulty:
Triaged:
Bugzilla link:
Description
Discovery rules are processed in order of :name, not :priority.
A simple fix is in line 9 of foreman_discovery-4.0.0/app/controllers/concerns/foreman/controller/discovered_extensions.rb:
- DiscoveryRule.where(:enabled => true).reorder(:priority).each do |rule| + DiscoveryRule.where(:enabled => true).order(:priority).each do |rule|
I don't know for sure, but think it could be related to foreman_discovery-4.0.0/app/models/discovery_rule.rb, which sets: order("discover_rules.name") around line 29:
# with proc support, default_scope can no longer be chained # include all default scoping here default_scope lambda { with_taxonomy_scope do order("discovery_rules.name") end }
Updated by Steve Parker almost 9 years ago
My apologies, reverse diff format in the original report. The fix is to use ".reorder" instead of ".order"
Updated by Lukas Zapletal over 8 years ago
- Category set to Image
- Assignee set to Lukas Zapletal
- Priority changed from Normal to Urgent
- Target version set to Discovery Plugin 6.0
Oh thanks!
Updated by Lukas Zapletal over 8 years ago
- Related to Bug #12765: Inconsistent rule ordering in the UI added
Updated by Lukas Zapletal over 8 years ago
- Target version changed from Discovery Plugin 6.0 to Discovery Plugin 5.0.2
What a nasty bug, Steve. Thanks for investigation!
Updated by Lukas Zapletal over 8 years ago
For the record, I am clearing our documentation which was also a bit fuzzy around this: https://github.com/theforeman/theforeman.org/pull/556
Updated by The Foreman Bot over 8 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman_discovery/pull/254 added
Updated by Lukas Zapletal over 8 years ago
- Target version changed from Discovery Plugin 5.0.2 to Discovery Plugin 5.0.3
Updated by Anonymous over 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset foreman_discovery|b1d5689467aa42c699c5e3a4904a2d278dbf8a31.
Actions