Bug #19250

Repo sync: several parameters not passed to pulp

Added by Brad Buckingham 16 days ago. Updated 15 days ago.

Status:Closed
Priority:Normal
Assigned To:Brad Buckingham
Category:Repositories
Target version:Team Brad - Iteration 13
Difficulty:easy Pull request:https://github.com/Katello/katello/pull/6747
Bugzilla link:1223023
Story points-
Velocity based estimate-
Release3.4.0Release relationshipAuto

Description

Observed that performing an 'Advanced Sync' -> 'Validate Content Sync' is not passing the following parameters from the dynflow action input to pulp via the REST API:

download_policy: on_demand
force_full: true
auto_publish: false

E.g. REST API observed:

2017-04-11 21:24:27 [katello/pulp_rest] [D] RestClient.post "https://centos7-katello-nightly.example.com/pulp/api/v2/repositories/94387fd8-35ac-41e2-b696-387cf333220a/actions/sync/", "{\"override_config\":{\"num_threads\":4,\"validate\":true}}", "Accept"=>"*/*; q=0.5, application/xml", "Accept-Encoding"=>"gzip, deflate", "Content-Length"=>"53", "accept"=>"application/json", "content_type"=>"application/json" | \n# => 202 Accepted | application/json 172 bytes

As a result of this, if an RPM is corrupted on the filesystem, it will not be corrected during the sync operation as expected.

Scenario:

- create a product (zoo)
- create a repo (zoo) with immediate download policy
- sync repo
- after sync completes, update repo to 'on demand' policy
- perform an Advanced Sync > Validate Content Sync
observe in the log (e.g. development.log) that the sync isn't including the additional parameters (listed above).

- the expected behavior is that all parameters would be included, similar to the following (observe: download_policy, force_full, & auto_publish):

2017-04-11 21:29:57 [katello/pulp_rest] [D] RestClient.post "https://centos7-katello-nightly.example.com/pulp/api/v2/repositories/94387fd8-35ac-41e2-b696-387cf333220a/actions/sync/", "{\"override_config\":{\"download_policy\":\"on_demand\",\"force_full\":true,\"auto_publish\":false,\"num_threads\":4,\"validate\":true}}", "Accept"=>"*/*; q=0.5, application/xml", "Accept-Encoding"=>"gzip, deflate", "Content-Length"=>"122", "accept"=>"application/json", "content_type"=>"application/json"

Associated revisions

Revision 222d933d
Added by Brad Buckingham 15 days ago

fixes #19250 - repo sync: several parameters not passed to pulp

Observed that several parameters associated with a 'Validate
Content Sync' were not passed to pulp, resulting in unexpected
behavior.

Refer to issue for more details:
http://projects.theforeman.org/issues/19250

History

#1 Updated by Brad Buckingham 16 days ago

  • Release set to 3.4.0
  • Bugzilla link set to 1223023

Note: this is related to bugzilla 1223023.

#2 Updated by Brad Buckingham 16 days ago

  • Target version set to Team Brad - Iteration 13

#3 Updated by The Foreman Bot 16 days ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/6747 added

#4 Updated by Brad Buckingham 15 days ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF