Refactor #19700

enable rubocop Performance/RedundantMerge and Performance/RedundantMatch

Added by Ohad Levy 11 months ago. Updated 11 months ago.

Status:Closed
Priority:Normal
Assigned To:Ohad Levy
Category:-
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4559
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

changes lines such as:

not_found_message.merge! :message => options
to:
not_found_message[:message] = options

and
converts str.match()
to
str =~ ()

Associated revisions

Revision cabe2c2e
Added by Ohad Levy 11 months ago

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()
- remove extra whitespaces etc.

History

#1 Updated by The Foreman Bot 11 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4559 added

#2 Updated by Ohad Levy 11 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Marek Hulán 11 months ago

  • Release set to 1.16.0

Also available in: Atom PDF