Refactor #19706

Don't treat DHCP leases as conflicts

Added by Lukas Zapletal 6 months ago. Updated about 1 month ago.

Status:Closed
Priority:Normal
Assigned To:Lukas Zapletal
Category:DHCP
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4555
Story points-
Velocity based estimate-
Release1.15.5Release relationshipAuto

Description

Our previous code that should ignore leases was based on existence of hostnames, it used to work but no longer works in recent releases. In smart-proxy, we added explicit flag to indicate if a DHCP record is a reservation or a lease: theforeman/smart-proxy#532

This patch leverages this and removes the old hostname "hack" to proper test if the existing record is a lease or not. Conflict is not thrown in that case.


Related issues

Related to Smart Proxy - Feature #19666: Return record type for DHCP recorts Closed 05/25/2017
Related to Foreman - Bug #21120: Updating PXE loader causes DHCP conflicts New 09/27/2017

Associated revisions

Revision a47c444d
Added by Lukas Zapletal about 1 month ago

Fixes #19706 - don't treat DHCP leases as conflicts

Revision f5aaaae0
Added by Lukas Zapletal about 1 month ago

Fixes #19706 - don't treat DHCP leases as conflicts

Revision 58390d0b
Added by Lukas Zapletal about 1 month ago

Fixes #19706 - don't treat DHCP leases as conflicts

History

#1 Updated by Lukas Zapletal 6 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4555 added

#2 Updated by Dominic Cleal 6 months ago

  • Related to Feature #19666: Return record type for DHCP recorts added

#3 Updated by Lukas Zapletal about 1 month ago

  • Related to Bug #21120: Updating PXE loader causes DHCP conflicts added

#4 Updated by The Foreman Bot about 1 month ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Lukas Zapletal

#5 Updated by Lukas Zapletal about 1 month ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Lukas Zapletal about 1 month ago

  • Release set to 1.15.5

Merged into 1.15.5 branch as well:

commit f5aaaae0a4a8282017985e2421b3198d95e56dc0
Refs: {dlobatog/1.15-stable}, 1.15.4-1-gf5aaaae0a
Author: Lukáš Zapletal <>
AuthorDate: Fri Oct 6 12:36:10 2017 +0200
Commit: Daniel Lobato Garcia <>
CommitDate: Fri Oct 6 12:37:05 2017 +0200

Fixes #19706 - don't treat DHCP leases as conflicts

Also available in: Atom PDF