Bug #20119

Be more descriptive when validating hostname

Added by Ivan Necas 6 months ago. Updated 5 months ago.

Status:Closed
Priority:Normal
Assigned To:-
Category:Inventory
Target version:Team Ivan Iteration 17
Difficulty: Bugzilla link:1375591
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4651, https://github.com/theforeman/foreman/pull/4663
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

Currently, we validate hostname with a regular expression. If the regular expression
doesn't match, the host name is considred as invalid, printing an info that
name is invalid. In some environments, it's not that uncommon to include
the '_' in the host name, and it's hard to user to figure out what exactly is wrong with
the name.

The new behaviour should be to explicitly mention that the host can't include
`_`, before using the regular expression.

Associated revisions

Revision 060d2004
Added by Boaz Shuster 5 months ago

Fixes #20119 - Be more descriptive when validating hostname

Signed-off-by: Boaz Shuster <>

Revision 657fdc0f
Added by François Cami 5 months ago

Refs #20119 - Be more descriptive when validating hostname

Explain that this is not Foreman's limitation, but comes from RFCs.

History

#1 Updated by Ivan Necas 6 months ago

  • Subject changed from Be more descriptive when validating hostname to Be more descriptive when validating hostname
  • Target version set to Team Ivan Iteration 17

#2 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4651 added

#3 Updated by Anonymous 5 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Marek Hulán 5 months ago

  • Release set to 1.16.0

#5 Updated by The Foreman Bot 5 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4663 added

Also available in: Atom PDF