Bug #7738

Some SSO methods may fail

Added by Marek Hulán over 3 years ago. Updated over 3 years ago.

Status:Closed
Priority:Normal
Assigned To:Marek Hulán
Category:Authentication
Target version:Sprint 30
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/1808
Story points-
Velocity based estimate-
Release1.6.1Release relationshipAuto

Description

While we were investigating #7737 we found that we rely on SSO backend to define logout_url. Some of SSO backeds don't define it. Also we need to get into state as if we didn't define it (Base > Apache (defines) > Intercept (undefine) so we should make logout_url returning nil in Base.


Related issues

Related to Foreman - Bug #7737: Change for issue 6999 broke logout for PAM-based (interce... Closed 09/29/2014

Associated revisions

Revision 5ed22f14
Added by Marek Hulán over 3 years ago

Fixes #7738 - logout_url is nil by default for all SSO backends

Revision 3074ecc1
Added by Marek Hulán over 3 years ago

Fixes #7738 - logout_url is nil by default for all SSO backends

(cherry picked from commit 5ed22f148b7238eef70cc38636cb9bc4624158ef)

History

#1 Updated by Marek Hulán over 3 years ago

  • Related to Bug #7737: Change for issue 6999 broke logout for PAM-based (intercept) authentication added

#2 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1808 added

#3 Updated by Marek Hulán over 3 years ago

I was too fast, try didn't raise it but we'd have two different states there - logout_url returning nil and sso_method.try(:logout_url) returning nil, so I think it's better to be explicit and don't use try.

#4 Updated by Dominic Cleal over 3 years ago

  • Target version changed from Sprint 29 to Sprint 30

#5 Updated by Marek Hulán over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Daniel Lobato Garcia over 3 years ago

  • Release set to 1.6.1

Also available in: Atom PDF