Actions
Bug #9720
closed
APIv1 subnets "ipam" documentation is inconsistent with v2
Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
API
Target version:
-
Difficulty:
trivial
Triaged:
Pull request:
Description
The APIv1 subnets documentation for the "ipam" attribute says it's a bool, but it's actually a string. The APIv2 docs are correct and just need copying to v1.
https://github.com/theforeman/foreman/blob/1.8.0-RC1/app/controllers/api/v1/subnets_controller.rb#L33
https://github.com/theforeman/foreman/blob/1.8.0-RC1/app/controllers/api/v2/subnets_controller.rb#L36
Updated by The Foreman Bot about 10 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2272 added
- Pull request deleted (
)
Updated by Marek Hulán about 10 years ago
This was changed as part of #6444, as suggested in PR we should probably introduce a compatibility layer in v1 controller rather than copying the same definition. Maybe we shouldn't have changed it in v2 either.
Updated by Tomer Brisker about 9 years ago
- Status changed from Ready For Testing to New
Updated by Tomer Brisker over 7 years ago
- Status changed from New to Rejected
API v1 is deprecated. Closing.
Actions