Project

General

Profile

Actions
Copy link

Bug #11170

closed

foreman-rake: setting complex parameters (arrays, hashes) broken?

Added by Robert Rauch over 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominic Cleal
Category:
Rake tasks
Target version:
1.9.1
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2586
Fixed in Releases:
Found in Releases:
1.8.2
Red Hat JIRA:

Description

Trying to set complex Foreman parameters (i.e. arrays or hashes) using foreman-rake results in various errors, i.e.

[root@foreman ~]# foreman-rake -- config -k trusted_puppetmaster_hosts -v '[ "foo.bar.com", "foo.baz.org" ]'
rake aborted!
A JSON text must at least contain two octets!

Tasks: TOP => config
(See full trace by running task with --trace)

Another variant:

[root@foreman ~]# foreman-rake -- config -k trusted_puppetmaster_hosts -v '["foo.bar.com", "foo.baz.org"]'       
rake aborted!
387: unexpected token at 'foo.bar.com,'

Tasks: TOP => config
(See full trace by running task with --trace)

Related issues 1 (0 open — 1 closed)

Related to Packaging - Bug #11275: hammer ... list --search with spaces in arg fails on SCL OSClosedDominic Cleal08/03/2015Actions
Actions
Copy link
 #1

Updated by Dominic Cleal over 9 years ago

This works on a dev installation, so I'm pretty sure it's a combination of foreman-rake and ruby193-rake, which both use double quoted strings with su etc to pass commands through.

Actions
Copy link
 #2

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2562 added
  • Pull request deleted ()
Actions
Copy link
 #3

Updated by Robert Rauch over 9 years ago

I have provided a PR, which should fix it, as far as the foreman-rake wrapper is concerned. The same issue applies to the ruby193-rake wrapper, which apperently is in use on some Systems (like Centos7). I guess the ruby193-rake wrapper is not controlled by the Foreman guys, so this should probably get fixed upstream.

Actions
Copy link
 #4

Updated by Dominic Cleal over 9 years ago

We actually adopted the ruby193 wrappers as they were removed from SCLs, so the source is over here now: https://github.com/theforeman/foreman-packaging/tree/rpm/develop/ruby-wrapper

I happened to fix this in an unmerged refactoring (https://github.com/theforeman/foreman-packaging/pull/249/files#diff-2092b3ff9c37e1fddb7536cd9beec494R161), so I can reapply my fix to the current version so we have both instances working.

Actions
Copy link
 #5

Updated by Dominic Cleal over 9 years ago

There's a further issue affecting SCL OSes in scl-utils itself: https://bugzilla.redhat.com/show_bug.cgi?id=1248418, so this will only fix it completely for the others. Once that's fixed we'll also need the fix to the ruby193-esque wrappers.

Actions
Copy link
 #6

Updated by Dominic Cleal over 9 years ago

  • Related to Bug #11275: hammer ... list --search with spaces in arg fails on SCL OS added
Actions
Copy link
 #7

Updated by Dominic Cleal over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #8

Updated by Dominic Cleal over 9 years ago

  • Assignee set to Dominic Cleal
  • Translation missing: en.field_release set to 72
  • Pull request https://github.com/theforeman/foreman/pull/2586 added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/2562)
Actions
Copy link

Also available in: Atom PDF