Project

General

Profile

Actions

Refactor #12476

closed

Refactor host collection validator for rails 4

Added by John Mitsch almost 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Branch:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

https://github.com/Katello/katello/blob/master/app/models/katello/system_host_collection.rb#L10-L18

needs to be moved as a validator on the relation table is not working correctly in rails 4. It is unable to recognize a host_collection_id on test_create in host collection controller tests.

Actions #1

Updated by John Mitsch almost 9 years ago

It looks like the validator is not working correctly on a host_collection create method, so a test should be added to check for this (all on master)

Actions #2

Updated by The Foreman Bot almost 9 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to John Mitsch
  • Pull request https://github.com/Katello/katello/pull/5610 added
Actions #3

Updated by John Mitsch almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Eric Helms over 8 years ago

  • Translation missing: en.field_release set to 86
Actions

Also available in: Atom PDF