Project

General

Profile

Bug #12805

lookup values not validating when parent key is invalid

Added by Tom Caspy over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Smart Variables
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

in puppetclass#edit
input invalid default value into some lookup key
then input an invalid value into a lookup value

the lookup value doesn't get validated at all.


Related issues

Has duplicate Foreman - Bug #8794: Smart variable validation stops after first errorDuplicate2014-12-28

Associated revisions

Revision 4db14e17 (diff)
Added by Tom Caspy over 3 years ago

fixes #12805 - nested LV in puppetclass form are now validated

Callbacks return false ONLY if they NEED to stop EVERYTHING else from
running!
DO NOT return false if you want to say "this isn't valid"

Revision 9383ba04 (diff)
Added by Tom Caspy over 3 years ago

fixes #12805 - nested LV in puppetclass form are now validated

Callbacks return false ONLY if they NEED to stop EVERYTHING else from
running!
DO NOT return false if you want to say "this isn't valid"

(cherry picked from commit 4db14e17662e6631c51164127830c42863657575)

History

#1 Updated by Dominic Cleal over 3 years ago

  • Category set to Smart Variables

#2 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tom Caspy
  • Pull request https://github.com/theforeman/foreman/pull/2980 added

#3 Updated by Tom Caspy over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) set to 104

#5 Updated by Tom Caspy over 3 years ago

  • Has duplicate Bug #8794: Smart variable validation stops after first error added

Also available in: Atom PDF