Project

General

Profile

Bug #13098

plugin assets fail to precompile with TypeError: couldn't digest ActiveSupport::StringInquirer

Added by Eric Helms almost 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugins-Engines
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

After the update to include Patternfly which required bumping sprockets to version 3+, plugin assets precompile task fails with:

TypeError: couldn't digest ActiveSupport::StringInquirer

Associated revisions

Revision 8eaa16f5 (diff)
Added by Eric Helms almost 4 years ago

Fixes #13098: Set assets environment the same as core assets

The introduction of Sprockets 3+ led to the environment-version
being set to ActiveSupport::StringInquirer object instead of a
String. The Sprockets digest method does not support digesting
classes of type ActiveSupport::StringInquirer.

This change explicitly sets the assets environment version to be
calculated the same as core assets when precompiling. When core
assets are precompiled using the normal Rails assets:precompile rake
task the environment string is generated in such a way as to create
a unique string and thus unique digest. The plugin:asset:precompile
task will now do the same and explicitly ensure it is set to
production given the task does not require a true Rails environment
to be declared.

History

#1 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Eric Helms
  • Pull request https://github.com/theforeman/foreman/pull/3038 added

#2 Updated by Dominic Cleal almost 4 years ago

  • Category set to Plugins-Engines
  • Legacy Backlogs Release (now unused) set to 71

#3 Updated by Eric Helms almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF