Project

General

Profile

Bug #16041

Unify accordion styles in show page

Added by Daniel Lobato Garcia over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Discovery plugin
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Currently the accordion in the left shows just a '+' button and the one in the right shows that, and the regular accordion caret. This makes it look a bit strange as the two symbols mean the same.
Furthermore, the 'highlights' title has a different font than the other titles.

Associated revisions

Revision b6eb17fe (diff)
Added by Daniel Lobato Garcia over 6 years ago

Fixes #16041 - Unify accordion styles in show page

This commit fixes the heading of highlights to look similar to the other
headings (used to violate the 'rule' of no more than 3 font-sizes/types
in the same page)

It also uses Patternfly's accordion carets instead of the +/- glyphicons
which we had to modify via javascript. That way we get rid of the
redundancy, conform to how Patternfly recommends accordions to look, and
we don't need to write any JS code for that.

History

#1 Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_discovery/pull/293 added

#2 Updated by Daniel Lobato Garcia over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF