Bug #16439
Don't fail rebuild if DNS record is already ok
Pull request:
Fixed in Releases:
Found in Releases:
Description
The attached PR changes the logic when rebuilding DNS records so that we don't fail if there's no update necessary or the record is nil. Currently we just report an error without any further explanation although everything is o.k. because the "unless" makes us return nil instead of true.
Associated revisions
Fixes #16439 - Don't fail recreate if DNS is ok
If rebuilding a host and DNS is not "feasible" we don't want to fail
that host but rather recreate what's currently feasible.
If a DNS record is still valid we don't want to fail that host but
rather take the still valid entry.
(cherry picked from commit 088c8f3d6fdbe9da1041a3812dae103f5c5a0cee)
History
#1
Updated by The Foreman Bot almost 5 years ago
Updated by - Status changed from New to Ready For Testing
- Assignee set to Guido Günther
- Pull request https://github.com/theforeman/foreman/pull/3812 added
#2
Updated by Guido Günther almost 5 years ago
Updated by - Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 088c8f3d6fdbe9da1041a3812dae103f5c5a0cee.
#3
Updated by Dominic Cleal almost 5 years ago
Updated by - Legacy Backlogs Release (now unused) set to 181
#4
Updated by Dominic Cleal over 4 years ago
- Legacy Backlogs Release (now unused) changed from 181 to 160
Not applicable to 1.12-stable.
Fixes #16439 - Don't fail recreate if DNS is ok
If rebuilding a host and DNS is not "feasible" we don't want to fail
that host but rather recreate what's currently feasible.
If a DNS record is still valid we don't want to fail that host but
rather take the still valid entry.