Project

General

Profile

Actions

Refactor #16567

closed

Use constants to register Rails middleware rather than strings

Added by Dominic Cleal almost 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Middleware is currently registered in config/application.rb using a string referring to the class name, but this is deprecated in Rails 5.0:

2016-09-15T14:29:33  [app] [W] DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change
 | them to actual class references.  For example:
 | 
 |   "Middleware::CatchJsonParseErrors" => Middleware::CatchJsonParseErrors
 | 
 |  (called from <top (required)> at /home/dcleal/code/foreman/foreman/config/environment.rb:5)

It will probably be removed in Rails 5.1.

Actions #1

Updated by The Foreman Bot almost 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3849 added
Actions #2

Updated by Dominic Cleal almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal almost 8 years ago

  • Translation missing: en.field_release set to 189
Actions

Also available in: Atom PDF