Refactor #18176: Replace call to private clear_association_cache in Subnet#known_ips - Foreman

Actions

Copy link

Refactor #18176

closed

Replace call to private clear_association_cache in Subnet#known_ips

Added by Dominic Cleal almost 8 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Low

Assignee:

Dominic Cleal

Category:

Rails

Target version:

1.15.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/4212

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The method clear_association_cache on models has been made private in Rails 5.0, it should be replaced where it's used in Subnet#known_ips:

NoMethodError: private method `clear_association_cache' called for #&lt;Subnet::Ipv4:0x0000000b9d15d8&gt;
Did you mean?  clear_transaction_record_state
    app/models/subnet.rb:190:in `known_ips'
    app/services/ipam/db.rb:11:in `block in suggest_ip'
    app/services/ipam/db.rb:9:in `suggest_ip'
    test/unit/nic_test.rb:220:in `block (2 levels) in &lt;class:NicTest&gt;' (NoMethodError)
activemodel-5.0.0/lib/active_model/attribute_methods.rb:430

The method was public, but undocumented - for use only by Rails. It is now private (https://github.com/rails/rails/commit/9d56958).

The purpose appears to be to ensure known_ips always returns up to date lists of IPs when used for IPAM. e.g. if an interface is created with a given subnet and allocated an IP, a second interface created with the same subnet object won't be allocated the same IP.