Project

General

Profile

Bug #1840

Help button shouldn't be shown if help page is missing.

Added by Nacho Barrientos almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Low
Assignee:
Sam Kottler
Category:
Web Interface
Target version:
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

Hi,

I'm on commit 938e78d647f943f0987c992c2f924dd81cba55b3.

nacho@ndnd: (develop) [0]
~/dev/foreman/app/views $ grep help_path compute_resources/index.html.erb 
<% title_actions display_link_if_authorized("New Compute Resource", hash_for_new_compute_resource_path), help_path %>
nacho@ndnd: (develop) [0]
~/dev/foreman/app/views $ ls compute_resources/welcome*
ls: cannot access compute_resources/welcome*: No such file or directory

(the obvious alternative is to write a welcome page ;)

Cheers.

Associated revisions

Revision 3e33d71f (diff)
Added by Sam Kottler almost 10 years ago

fixes #1840 Only show the help button if a help page exists

History

#1 Updated by Ohad Levy almost 10 years ago

Great! when do we get it ? ;)

#2 Updated by Sam Kottler almost 10 years ago

  • Assignee set to Sam Kottler

This is really easy. Assigning it to myself to do this week.

#3 Updated by Sam Kottler almost 10 years ago

  • Status changed from New to Feedback

I've submitted a pull request with a proposed fix - https://github.com/theforeman/foreman/pull/146.

#4 Updated by Ohad Levy almost 10 years ago

  • Category changed from Compute resources to Web Interface
  • Status changed from Feedback to Assigned
  • Target version set to 1.1

#5 Updated by Anonymous almost 10 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF