Project

General

Profile

Bug #18510

remote execution job schedule and details page does not handle search query returning 0 hosts too well

Added by Adam Ruzicka over 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Usability
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1417807

Description of problem:
With search query matching 0 hosts, remote execution job schedule page:

Preview keeps screen grayed, without preview window and [close] button at all, not error message shown

And details page (this is only for "Update Package - Katello SSH Default through SSH" template):

In "Preview for target", there is "Warning! error during rendering: undefined method 'operatingsystem' for NilClass::Jail (NilClass)" instead of some simple error message

These two pages does not handle search query returning 0 hosts too well

Version-Release number of selected component (if applicable):
satellite-6.2.6-2.0.el7sat.noarch

How reproducible:
always

Steps to Reproduce:
1. Schedule remote execution job Monitor -> Jobs -> [Run job] with host
search query "name ~ such_a_host_does_not_exists"
2. Click icon of "eye" to preview matching hosts
3. Also try to schedule with:
Job category: Katello
Job template: Update Package...
and check "Preview for target" section

Actual results:
On schedule page if you click on preview button, it grays the screen and there is no way back.
On details page it shows template rendering warning

Expected results:
Should be possible to close grayed page and instead of template rendering error there should be informative error message like "No host matches the search query"

Associated revisions

Revision 849f361c (diff)
Added by Adam Ruzicka over 5 years ago

Fixes #18510 - Display warning when search query matches no host

History

#1 Updated by Adam Ruzicka over 5 years ago

  • Category set to Usability
  • Target version set to 113

#2 Updated by Adam Ruzicka over 5 years ago

Getting preview of the hosts seems to work, rendering a template preview does not

#3 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Adam Ruzicka
  • Pull request https://github.com/theforeman/foreman_remote_execution/pull/230 added

#4 Updated by Ivan Necas over 5 years ago

  • Target version changed from 113 to 1.12.0

#5 Updated by Adam Ruzicka over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF