Project

General

Profile

Bug #18950

ComputeResourceIntegrationTest#test_0003_compute resource password [..] fails on capybara 2.13.0

Added by Dominic Cleal about 2 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Since the release of capybara 2.13.0, the following test fails on develop:

ComputeResourceIntegrationTest#test_0003_compute resource password doesn't deleted while test connection [/home/dcleal/code/foreman/foreman/test/integration/compute_resource_test.rb:23]:
Expected: "123456" 
  Actual: nil

It passes under 2.12.1. It appears to rely upon editing a disabled password field, which is probably the fault, as the value of the field isn't updated when it's filled.

Associated revisions

Revision b9c0ea89 (diff)
Added by Dominic Cleal about 2 years ago

fixes #18950 - enable password field in CR form test

Prior to capybara 2.13.0, the test passed despite filling in a disabled
password field, but a change now prevents this odd assumption. The test
now enables the field via the provided button, also requiring JS.

Revision e53fd8e1 (diff)
Added by Dominic Cleal about 2 years ago

refs #18950 - wait for CR test connection to complete

Revision d989698e (diff)
Added by Dominic Cleal about 2 years ago

fixes #18950 - enable password field in CR form test

Prior to capybara 2.13.0, the test passed despite filling in a disabled
password field, but a change now prevents this odd assumption. The test
now enables the field via the provided button, also requiring JS.

(cherry picked from commit b9c0ea89039797a7e5617e922947472e1170ebb2)

Revision cf4fa3d5 (diff)
Added by Dominic Cleal about 2 years ago

refs #18950 - wait for CR test connection to complete

(cherry picked from commit e53fd8e1b24fe7d0d578bb73243a0c28d66e7638)

History

#1 Updated by The Foreman Bot about 2 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4386 added

#2 Updated by Dominic Cleal about 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal about 2 years ago

  • Legacy Backlogs Release (now unused) set to 227

#4 Updated by The Foreman Bot about 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4397 added

Also available in: Atom PDF