Project

General

Profile

Bug #20173

Concurrent calls to Subnet#unused_ip may return the same ip address

Added by Dmitri Dolguikh over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dmitri Dolguikh
Category:
DHCP
Target version:
1.15.4
Difficulty:
Triaged:
Bugzilla link:
1459644
Pull request:
https://github.com/theforeman/smart-proxy/pull/534
Fixed in Releases:
Found in Releases:

Description

In the time between lock file existence check and lock file creation it is possible for other threads to successfully pass File.exists? check, therefore creating a race condition.

Related issues

Related to Smart Proxy - Bug #20474: Multiple free IPs returned after record deletionClosed2017-08-01
Related to Smart Proxy - Feature #23406: Foreman should pre allocate ip addresses in IPAM to prevent conflictsDuplicate2018-04-26
Related to Infoblox - Bug #23523: Infoblox DHCP gives unreliable free IPsNew

Associated revisions

Revision 37e40729 (diff)
Added by Dmitri Dolguikh over 3 years ago

Fixes #20173,#6819 - removed race condition in Subnet#unused_ip

History

#1 Updated by Dmitri Dolguikh over 3 years ago

  • Bugzilla link set to 1459644

#2 Updated by Dmitri Dolguikh over 3 years ago

  • Category set to DHCP

#3 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Dmitri Dolguikh
  • Pull request https://github.com/theforeman/smart-proxy/pull/534 added

#4 Updated by Anonymous over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Lukas Zapletal about 3 years ago

  • Related to Bug #20474: Multiple free IPs returned after record deletion added

#6 Updated by Lukas Zapletal about 3 years ago

  • Legacy Backlogs Release (now unused) set to 287

BZ associated, we need a cherry pick thanks.

#7 Updated by Lukas Zapletal over 2 years ago

  • Related to Feature #23406: Foreman should pre allocate ip addresses in IPAM to prevent conflicts added

#8 Updated by Dmitri Dolguikh over 2 years ago

  • Related to Bug #23523: Infoblox DHCP gives unreliable free IPs added

Also available in: Atom PDF