Actions
Bug #21419
closedReverse logic of setfacl_etc_dhcp and setfacl_var_lib_dhcp
Difficulty:
Triaged:
Bugzilla link:
Description
setfacl installer code is working but with reverse logic, see:
1. Set ACL- setfacl -R -m u:foreman-proxy:rx /var/lib/dhcpd /etc/dhcp
- satellite-installer -v
...
[ WARN 2017-10-22 06:48:16 verbose] /Stage[main]/Foreman_proxy::Proxydhcp/Exec[setfacl_etc_dhcp]/returns: executed successfully
[ WARN 2017-10-22 06:48:16 verbose] /Stage[main]/Dhcp/Concat[/etc/dhcp/dhcpd.conf]/File[/etc/dhcp/dhcpd.conf]/mode: mode changed '0654' to '0644'
[ INFO 2017-10-22 06:48:16 verbose] Concat[/etc/dhcp/dhcpd.conf]: Scheduling refresh of Service[dhcpd]
...
2. Remove ACLwhen acl is present installer sets it !!!
- setfacl -R -x u:foreman-proxy /var/lib/dhcpd /etc/dhcp
- satellite-installer -v
...
<no exec of setfacl_etc_dhcp>
...
when acl is not set installer doesn't set it !!!
Moreover, setfacl_var_lib_dhcp has typo!!!
onlyif => "getfacl -p /var/lib/dhcp | grep user:${::foreman_proxy::user}:r-x"
/var/lib/dhcp doesn't exist it should be /var/lib/dhcpd
Updated by The Foreman Bot almost 7 years ago
- Status changed from New to Ready For Testing
- Assignee set to Ewoud Kohl van Wijngaarden
- Pull request https://github.com/theforeman/puppet-foreman_proxy/pull/386 added
Updated by Lukas Pramuk almost 7 years ago
- Related to Bug #20683: Upgrade of dhcpd always breaks permissions added
Updated by Ewoud Kohl van Wijngaarden almost 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset puppet-foreman_proxy|9041338dee70b16c9a8e740b32f164d8643ff3b3.
Actions