Bug #22718

Hammer does not error when not all items in list of ids are resolved

Added by Martin Bacovsky 5 months ago. Updated 6 days ago.

Status:Closed
Priority:High
Assignee:Martin Bacovsky
Category:Foreman commands (obsolete)
Target version:hammer-cli-foreman-0.12.1
Difficulty: Team Backlog:
Triaged: Fixed in Releases:
Bugzilla link: Found in Releases:Foreman - Nightly
Pull request:https://github.com/theforeman/hammer-cli-foreman/pull/356

Description


hammer role create --name a
hammer user-group create --name ug1 --admin true --roles 'a,m'
User group [ug1] created.

But after checking the logs that only role with id = 1 was added.

This is caused by how resolver is counting expected records.
It tries to guess if it is looking up records for resource in singular or plural from the options.
When both (e.g. --name and --names) are present it will pick singular and thus expects just one record.
In the example above the scoped options contain both name = ug1 and names = 'a,m' and the logic fails.

Associated revisions

Revision b05b5418
Added by Martin Bacovsky 4 months ago

Fixes #22718 - raise error when wrong number of ids is resolved

History

#1 Updated by Martin Bacovsky 5 months ago

  • Target version changed from 246 to 249

#2 Updated by The Foreman Bot 5 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/356 added

#3 Updated by Martin Bacovsky 4 months ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#4 Updated by Martin Bacovsky 4 months ago

  • Legacy Backlogs Release (now unused) set to 342

Also available in: Atom PDF