Project

General

Profile

Actions
Copy link

Bug #24139

closed

foreman_salt does not recognize vlan interfaces (and bonds/bridges) as virtual interfaces

Added by Danny S over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Foreman Integration
Target version:
-
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_salt/pull/80
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The foreman_salt FactParser doesn’t recognize VLAN interfaces (and bond/bridges) as virtual interfaces. The first cause is that VLAN interfaces are often defined is <iface>.<vlan>. That syntax wasn't recognized by foreman core until: https://github.com/theforeman/foreman/pull/5597
That change makes foreman core recognize the syntax, however it still doesn't work with the salt plugin. The cause is that the foreman_salt FactParser doesn’t add additional attributes based on VIRTUAL, BRIDGES, BONDS regex of foreman core.

It seems that adding a call to ‘set_additional_attributes’ in the FactParser can fix that. I will add a PR for that.

This came up as part of this discussion: https://community.theforeman.org/t/detection-of-changes-in-host-network-configuration-by-foreman/10039

Actions
Copy link

Also available in: Atom PDF