Project

General

Profile

Bug #2738

smart-proxy for puppet not picking up whole module path

Added by David Blank-Edelman about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Smart proxies
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Using 1.2 of foreman-proxy package from the Ubuntu precise repo, I find that the smart proxy isn't picking up my whole modulepath and hence classes importing is problematic.

The proxy config says:

:puppet: true
:puppet_conf: /etc/puppet/puppet.conf

The relevant parts of /etc/pupet/puppet.conf say:

[main]
    confdir = /etc/puppet-master-conf/master-conf
...
[master]
    environment = production
    manifest = $confdir/environments/$environment/manifests/site.pp
    modulepath = $confdir/environments/$environment/modules:$confdir/environments/$environment/service

But when I talk to my proxy, I see:

$ curl proxy:8443/puppet/environments
["master","msimmons","production","dnb","cmccoy"]

$ curl proxy:8443/puppet/environments/dnb
{"name":"dnb","paths":["/etc/puppet-master-conf/master-conf/environments/dnb/services"]}

when indeed the $confdir/environments/$environment/module path is there and is readable by
the proxy user:

# sudo -u foreman-proxy ls -l /etc/puppet-master-conf/master-conf/environments/dnb/modules

drwxrwxr-x 7 puppet puppet 4096 Jun 28 16:20 activemq
drwxrwxr-x 5 puppet puppet 4096 Jun 28 16:20 apt
drwxrwxr-x 4 puppet puppet 4096 Jun 28 16:20 autofs
...

Any help you can offer would be much appreciated.


Related issues

Has duplicate Smart Proxy - Bug #2768: importing classes partially fails when dynamic modulepath has multiple entriesRejected2013-07-10

Associated revisions

Revision e4ee928b (diff)
Added by Daniel Baeurer about 6 years ago

fixes #2738 - handle multiple dynamic modulepaths

Revision 28e250dd (diff)
Added by Daniel Baeurer about 6 years ago

fixes #2738 - handle multiple dynamic modulepaths
(cherry picked from commit e4ee928b03470ec085bc3c954405279421ccc52f)

History

#1 Updated by Dominic Cleal about 6 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 1.2.1

I think that's covered by this PR.

https://github.com/theforeman/smart-proxy/pull/98

#2 Updated by David Blank-Edelman about 6 years ago

Thanks Dominic, that's looking very plausible. I'll test it a little later today and let you know.

#3 Updated by David Blank-Edelman about 6 years ago

Ok, I couldn't wait.

The change to environments.rb in that PR worked great. Please feel free to close out this issue (ideally after the merge).

Thanks for your help and thanks to Danie for the work in the PR!

#4 Updated by Dominic Cleal about 6 years ago

Excellent, thanks for the feedback. We'll get it reviewed and merged.

#5 Updated by Anonymous about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Applied in changeset commit:"28e250ddcd4a0e370a58456d568b49a6ef6e1b35".

Also available in: Atom PDF