Bug #2758
On class reimport, Foreman runs class parameter validations even when parameter override is disabled
Description
This is running Foreman 1.2 RC3 (although I believe 1.2 would have the issue as well).
I believe the issue arose when I enabled override on an inherited parameter, changed its value, changed its type from string to something else, disabled the override, and then later tried to reimport after I made a class change.
Related issues
Associated revisions
History
#1
Updated by Jon McKenzie over 9 years ago
Sorry for brevity, will include more details when I get time to sit down and reproduce the issue.
#2
Updated by Dominic Cleal over 9 years ago
- Category set to Puppet integration
- Target version set to 1.3.0
This results in a message saying "Validation failed: Default value is invalid" when you try a puppet class import.
See also https://groups.google.com/forum/#!topic/foreman-users/TKi3ublJnSA for more discussion.
I'm setting this to 1.3 as we get lots of reports of this on IRC, but I didn't know what caused it until now. Thanks Jon!
#3
Updated by Andy Bohne over 9 years ago
I've got a fix for this. Should I branch off 1.2-stable or should I branch off develop? Assuming if I branch off 1.2-stable, the fix will make it into a release in the 1.2 series and we won't have to wait until 1.3.
#4
Updated by Dominic Cleal over 9 years ago
- Description updated (diff)
Andy Bohne wrote:
I've got a fix for this. Should I branch off 1.2-stable or should I branch off develop? Assuming if I branch off 1.2-stable, the fix will make it into a release in the 1.2 series and we won't have to wait until 1.3.
Great, please branch from develop and send a PR there. I'll try and get it in 1.2 if we do another release (1.2.1 is being finalised, it won't make that).
#5
Updated by Andy Bohne over 9 years ago
Dominic Cleal wrote:
Andy Bohne wrote:
I've got a fix for this. Should I branch off 1.2-stable or should I branch off develop? Assuming if I branch off 1.2-stable, the fix will make it into a release in the 1.2 series and we won't have to wait until 1.3.
Great, please branch from develop and send a PR there. I'll try and get it in 1.2 if we do another release (1.2.1 is being finalised, it won't make that).
OK. PR 831 has been submitted.
#6
Updated by Dominic Cleal over 9 years ago
- Status changed from New to Ready For Testing
#7
Updated by Anonymous over 9 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 537e2cad4eb5f43573d891efadb97f5676ee81e2.
#8
Updated by Dominic Cleal over 9 years ago
- Has duplicate Bug #3773: puppet class key update type change results in default_value invalid (1.2.2) added
Fixes #2758 - Reset key_type when importing parameter defaults