Bug #28003: VM is allways created with 1 vCPU - Xen - Foreman

Custom queries

All issues closed in the last 3 weeks
Easy and Trivial Issues
Good first issues - Foreman core
Mine
My issues closed in the last 3 weeks
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #28003

closed

VM is allways created with 1 vCPU

Added by Nikola Belavic over 4 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Difficulty:

trivial

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman-xen/pull/68

Fixed in Releases:

Found in Releases:

1.7.2

Red Hat JIRA:

Description

I am using foreman xen plugin to create new VMs. I am using network based provisioning.
Everything is OK, except VCPU - all VMs are always created with only 1 vCPU

Foreman Version 1.22
ruby-foreman-xen (1.0.0-1) - installed from debian package
OS: Debian 9.9
XCP-ng (Xenserver fork) version 7.6 (all features should be identical to Xenserver 7.6)

I have searched foreman and xen logs, but i didn't found anything usefull. If you want, i cann provide these logs.

Files

foreman-production.log	foreman-production.log	18.6 KB	foreman production.log	Nikola Belavic, 10/04/2019 04:02 PM
xensource.log	xensource.log	38.5 KB	log file from xcp-ng pool master	Nikola Belavic, 10/04/2019 04:02 PM

History
Notes
Property changes
Associated revisions

Actions

Copy link Download all files

Updated by Nikola Belavic over 4 years ago

File xensource.log xensource.log added
File foreman-production.log foreman-production.log added

Here are log files...

Actions

Copy link

Updated by Nikola Belavic over 4 years ago

I found this in audit.log on xcp-ng:

Oct 4 15:06:37 alphecca01 xapi: [20191004T13:06:37.984Z|audit|alphecca01|9936812 INET :::80|VM.create R:86eee6b15ab0|audit] ('trackid=fa7f9026338190078d18840400cc4eab' 'LOCAL_SUPERUSER' 'root' 'ALLOWED' 'OK' 'API' 'VM.create' (('name_description' 'To use this template from the CLI, install your VM using vm-install, then set other-config-install-repository to the path to your network repository, e.g. http://<server>/<path> or nfs:server:/<path>' '' '') ('ha_always_run' 'B(false)' '' '') ('ha_restart_priority' '' '' '') ('is_a_template' 'B(false)' '' '') ('memory_dynamic_max' '4294967296' '' '') ('memory_dynamic_min' '4294967296' '' '') ('memory_static_max' '4294967296' '' '') ('memory_static_min' '4294967296' '' '') ('memory_target' '0' '' '') ('name_label' 'blake-pridgen.testbla2.local' '' '') ('affinity' 'alphecca02' 'f18509a2-64f4-401a-8009-364bc9c49aa1' 'OpaqueRef:987ef14b-5065-44bf-9a94-de78d730fdbe')))

There is no mention of vcpu settings...

Actions

Copy link

Updated by Nikola Belavic over 4 years ago

Priority changed from Normal to Urgent
Assignee set to Anonymous

Actions

Copy link

Updated by Anonymous over 4 years ago

Priority changed from Urgent to Low
Assignee deleted (~~Anonymous~~)

Please do not assign issues to random people.

Actions

Copy link

Updated by Nikola Belavic over 4 years ago

Sorry about that :(
I just thought you are most skilled to resolve this...
I am fighting with this for a long time now, but i am failing to resolve it (i don't have adequate ruby knowledge).
I am using foreman for baremetal provisioning and this plugin would be great addition for vm provisioning.

Please help!

Actions

Copy link

Updated by Nikola Belavic over 4 years ago

I think i found problem.
I did some additional logging in gems/foreman_xen-1.0.0/app/models/foreman_xen/xenserver.rb and found out that after

(line 348)     vm_attr = template.attributes.dup.merge(attr)

i have duplicate args in "vm_attr" (vcpus_max, VCPUs_max and vcpus_at_startup, VCPUs_at_startup), so i did a following:

root@foreman-2-master:/usr/share/foreman/vendor/ruby/2.3.0/gems/foreman_xen-1.0.0/app/models/foreman_xen# diff -u xenserver.rb-orig xenserver.rb
--- xenserver.rb-orig   2020-01-28 16:59:06.710976277 +0100
+++ xenserver.rb        2020-01-29 12:29:49.076579264 +0100
@@ -273,8 +273,8 @@
       {
         name:               args[:name],
         name_description:   args[:comment],
-        VCPUs_max:          args[:vcpus_max],
-        VCPUs_at_startup:   args[:vcpus_max],
+        vcpus_max:          args[:vcpus_max],
+        vcpus_at_startup:   args[:vcpus_max],
         memory_static_max:  args[:memory_max],
         memory_dynamic_max: args[:memory_max],
         memory_dynamic_min: args[:memory_min],
@@ -346,6 +346,15 @@

After that, creating VM from template works as expected.
Can somebody please check/verify this and implement in next release?
I am not a developer, maybe there is better solution (like automatic conversion to lowercase, or something?).

Actions

Copy link