Feature #29822
open
Consolidate checks/ and hooks that act as checks as a mechanism that works like hooks
Description
Current state is there is a Kafo feature called checks/ to provide "system" checks before the installation runs. There are also hooks/ that provide similar functionality, e.g.
https://github.com/theforeman/foreman-installer/blob/develop/katello/hooks/pre/15-check_java.rb
https://github.com/theforeman/foreman-installer/blob/develop/katello/hooks/pre/15-check-disk.rb
https://github.com/theforeman/foreman-installer/blob/develop/katello/hooks/pre_validations/10-check_foreman_proxy_pulp.rb
The hooks concept provides more access to tools, and related data such as input parameters and the answers file than does the checks/ directory. These two should be re-conciled into hooks.
Possible ideas:
- create a dedicated checks/ hook phase to make it obvious
Updated by Eric Helms almost 4 years ago
- Blocks Feature #29802: Replace --skip-check-i-know-better with --disable-system-checks from katello/hooks added
Updated by Ewoud Kohl van Wijngaarden almost 4 years ago
- Related to Feature #29459: Ability to skip invididual checks added
Updated by Ewoud Kohl van Wijngaarden almost 4 years ago
It would also be nice if you could skip some, like CPU or DNS rather than wholesale everything. Linked it to #29459.
Updated by Ewoud Kohl van Wijngaarden over 1 year ago
- Blocks deleted (Feature #29802: Replace --skip-check-i-know-better with --disable-system-checks from katello/hooks)