Project

General

Profile

Bug #30720

hammer auth login oauth breaks convention by using dash as word separator in option value

Added by Mirek Długosz 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Team Backlog:
Found in Releases:
In Kanboard:

Description

hammer auth login oauth is the only place in hammer where option value uses dash as word separator, instead of underscore.

$ hammer auth login oauth --help
Usage:
    hammer auth login oauth [OPTIONS]

Options:
 -a, --oidc-authorization-endpoint OPENIDC-AUTHORIZATION-ENDPOINT Openidc provider URL which issues authentication code (two factor only)
 -c, --oidc-client-id OPENIDC-CLIENT-ID                           Client id used in the Openidc provider
 -f, --two-factor                                                 Authenticate with two factor
 -h, --help                                                       Print help
 -p, --password PASSWORD                                          Password to access the remote system
 -r, --oidc-redirect-uri OPENIDC-REDIRECT-URI                     Redirect URI for the authentication code grant flow
 -t, --oidc-token-endpoint OPENIDC-TOKEN-ENDPOINT                 Openidc provider URL which issues access token
 -u, --username USERNAME                                          Username to access the remote system

Compare with e.g. hammer report-template schedule (some lines skipped)

$ hammer report-template schedule --help
Usage:
    hammer report-template schedule [OPTIONS]

Options:
 --generate-at GENERATE_AT               UTC time to generate report at
 --gzip GZIP                             Compress the report using gzip
                                         One of true/false, yes/no, 1/0.
 --mail-to MAIL_TO                       If set, scheduled report will be delivered via e-mail. Use ',' to
                                         Separate multiple email addresses.
 --path PATH                             Path to directory where downloaded content will be saved. Only usable if wait is specified
 --report-format REPORT_FORMAT           Report format, defaults to 'csv'

To be specific, OPENIDC-AUTHORIZATION-ENDPOINT vs GENERATE_AT - it should be OPENIDC_AUTHORIZATION_ENDPOINT

Associated revisions

Revision 8514b5db (diff)
Added by Mirek Długosz 8 months ago

Fixes #30720 - use underscores in `login oauth` option values (#536)

History

#1 Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/536 added

#2 Updated by The Foreman Bot 8 months ago

  • Fixed in Releases hammer-cli-foreman-2.3.0 added

#3 Updated by Anonymous 8 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by The Foreman Bot 8 months ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/538 added

#5 Updated by Oleh Fedorenko 8 months ago

  • Fixed in Releases hammer-cli-foreman-2.1.3 added

#6 Updated by Oleh Fedorenko 8 months ago

  • Triaged changed from No to Yes

Also available in: Atom PDF