Project

General

Profile

Actions

Bug #32050

closed

BatchRunnerAction collect broadcasted output even if it has no use for it

Added by Adam Ruzicka about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

When ansible runner is used, then for each batch we have the following task structure on the smart proxy:
- 1 ForemanTasksCore::SingleRunnerBatchAction - a single parent task covering the batch
- 1 ForemanTasksCore::BatchRunnerAction - a single action running ansible-runner and dispatching updates to other actions
- N ForemanTasksCore::OutputCollectorAction - these just collect outputs from BatchRunnerAction to maintain one to one mapping between tasks in foreman and on the proxy. one for each host in the job

We distinguish two kinds of outputs - per-host and broadcast. Broadcast outputs are sent to all OutputCollectorAction, per-host are sent only to a specific OutputCollectorAction belonging to the given host. For some reason, BatchRunnerAction collects broadcasted outputs, although they are never consumed anywhere and just lead to unnecessary db writes and bloat.

Actions #1

Updated by The Foreman Bot about 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Adam Ruzicka
  • Pull request https://github.com/theforeman/foreman-tasks/pull/618 added
Actions #2

Updated by Adam Ruzicka about 3 years ago

  • Target version set to foreman-tasks-4.1.0
Actions #3

Updated by The Foreman Bot about 3 years ago

  • Fixed in Releases foreman-tasks-4.1.0 added
Actions #4

Updated by Adam Ruzicka about 3 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Adam Ruzicka about 3 years ago

  • Target version changed from foreman-tasks-4.1.0 to foreman-tasks-core-0.3.5
  • Fixed in Releases deleted (foreman-tasks-4.1.0)
Actions #6

Updated by Adam Ruzicka about 3 years ago

  • Fixed in Releases foreman-tasks-core-0.3.5 added
Actions

Also available in: Atom PDF