Project

General

Profile

Actions
Copy link

Refactor #32258

closed

Change default implementation of to_status to noop

Added by Shimon Shtein almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Shimon Shtein
Category:
Plugin integration
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8430, https://github.com/theforeman/foreman/pull/8459
Fixed in Releases:
2.5.0
Found in Releases:
Red Hat JIRA:

Description

Currently to_status method (https://github.com/theforeman/foreman/blob/f5bfce8bc5cab43fa66c362d40ee843e0783fe72/app/models/host_status/status.rb#L29) of status subclasses throws an exception if not implemented.

There are cases that need external event to happen in order to determine the correct status for a host. For such cases to_status method is unnecessary, and probably won't be implemented. We need to change the default implementation to noop

Actions
Copy link
 #1

Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8430 added
Actions
Copy link
 #2

Updated by The Foreman Bot almost 4 years ago

  • Fixed in Releases 2.5.0 added
Actions
Copy link
 #3

Updated by Shimon Shtein almost 4 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #4

Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/8459 added
Actions
Copy link

Also available in: Atom PDF