Refactor #32258
Change default implementation of to_status to noop
Difficulty:
Triaged:
No
Description
Currently to_status method (https://github.com/theforeman/foreman/blob/f5bfce8bc5cab43fa66c362d40ee843e0783fe72/app/models/host_status/status.rb#L29) of status subclasses throws an exception if not implemented.
There are cases that need external event to happen in order to determine the correct status for a host. For such cases to_status method is unnecessary, and probably won't be implemented. We need to change the default implementation to noop
Associated revisions
Refs #32258 - Added documentation about status class
History
#1
Updated by The Foreman Bot almost 2 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/8430 added
#2
Updated by The Foreman Bot almost 2 years ago
- Fixed in Releases 2.5.0 added
#3
Updated by Shimon Shtein almost 2 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman|13b3ce2243cdbc325d0d42ed28503a67397e98a3.
#4
Updated by The Foreman Bot almost 2 years ago
- Pull request https://github.com/theforeman/foreman/pull/8459 added
Fixes #32258 - Change to_status default to noop