Project

General

Profile

Actions
Copy link

Bug #32944

closed

foreman-maintain os major detection

Added by Emmanuel Vanlaar almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman_maintain/pull/498, https://github.com/theforeman/foreman_maintain/pull/482
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

the helper routines 'el7?' and 'el8?' in foreman_maintain/concerns/system_helpers.rb contain an error:
an assignment is done instead of equality check

def el7?
os_facts['os']['release']['major'] = '7' && el?
end

should be

def el7?
os_facts['os']['release']['major'] == '7' && el?
end

Actions
Copy link
 #1

Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_maintain/pull/498 added
Actions
Copy link
 #2

Updated by Amit Upadhye almost 4 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #3

Updated by The Foreman Bot over 3 years ago

  • Pull request https://github.com/theforeman/foreman_maintain/pull/482 added
Actions
Copy link

Also available in: Atom PDF