Project

General

Profile

Actions
Copy link

Refactor #34424

open

Deprecate Foreman::Cast.to_bool in favor of Rails implementation

Added by Ondřej Ezr almost 3 years ago. Updated about 2 years ago.

Status:
Ready For Testing
Priority:
Normal
Assignee:
-
Category:
Rails
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/9394
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

We have our own implementation of casting booleans, but we should not reimlement things that Rails provide.

We should deprecate Foreman::Cast.to_bool in favor of ActiveRecord::Type::Boolean.new.deserialize

This came up from a discussion on https://github.com/theforeman/foreman/pull/9079#discussion_r796700058

Actions
Copy link
 #1

Updated by The Foreman Bot about 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9394 added
Actions
Copy link

Also available in: Atom PDF