Project

General

Profile

Actions

Bug #35167

closed

Move hostgroups dropdown actions to an extendable helper

Added by Nofar Alfassi over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Host groups
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Adding the Ansible plugin overrides the `Actions` menu on the Hostgroups page.
The code on Github - https://github.com/theforeman/foreman_ansible/blob/c31e984a66ee2bf6a74756a981abc5c4dced108b/app/overrides/hostgroup_play_roles.rb

The actions array used from Ansible - https://github.com/theforeman/foreman_ansible/blob/c31e984a66ee2bf6a74756a981abc5c4dced108b/app/views/foreman_ansible/ansible_roles/_hostgroup_ansible_roles_button.erb#L8

So if we change something on the original actions array, we won't see it when using the Ansible plugin.

Should we keep it like that and fix this by applying the changes from the original actions array, or maybe we should extend it using pagelets?

Actions #1

Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/9297 added
Actions #2

Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases 3.4.0 added
Actions #3

Updated by Nofar Alfassi over 1 year ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Category set to Host groups
Actions #5

Updated by Nofar Alfassi over 1 year ago

  • Subject changed from Ansible plugin overrides the drop-down menu on the Hostgroups page to Move hostgroups dropdown actions to an extendable helper
Actions

Also available in: Atom PDF