Project

General

Profile

Actions

Bug #38137

closed

Do not double-escape "*" during package update

Added by Chris Roberts 3 days ago. Updated 1 day ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Hosts
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

What are the changes introduced in this pull request?
Update the "Update packages by search query - Katello Ansible Default" template to pass a simple * instead of "*" to the upstream "Package Action - Ansible Default" template. This makes it possible to upgrade all packages via Ansible using Katello 4.14 (and other versions).

The current template is erroring out:

fatal: [test-vm-01.example.org]: FAILED! => {"changed": false, "failures": ["No package \"*\" available."], "msg": "Failed to install some of the specified packages", "rc": 1, "results": []}
Considerations taken when implementing this change?
I tried to fix this as early as possible in the template call tree, to keep the change as minimal as possible.
The change has been working well on my production for a while. Most likely other users have heavier customizations to the scripts.
What are the testing steps for this pull request?
Configure Foreman/Katello to use Ansible for all actions
Select all upgradable packages for a host in the UI, and "Upgrade" all the packages through REX
It updates all packages and doesn't fail

Actions #1

Updated by The Foreman Bot 2 days ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/11273 added
Actions #2

Updated by The Foreman Bot 1 day ago

  • Fixed in Releases Katello 4.16.0 added
Actions #3

Updated by Lucas souza 1 day ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF