Project

General

Profile

Feature #502

Foreman can use the default HTTP provider now provided in puppet core

Added by Andrew Forgue almost 9 years ago. Updated almost 6 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

There's the default HTTP provider that's included in puppet core now for the puppet-dashboard. I think foreman should use this HTTP report to eliminate code duplication.

https://github.com/puppetlabs/puppet/blob/master/lib/puppet/reports/http.rb

Looks like the difference between the report parsers, foreman accepts the YAML in a report variable, whereas the dashboard uses request.raw_post. To get it working in my environment, I changed line 34 in reports_controller.rb from:

if Report.import params.delete("report")

to

if Report.import (params[:report].nil? ? request.raw_post : params[:report])

History

#1 Updated by Benjamin Papillon almost 6 years ago

  • Description updated (diff)
  • Status changed from New to Rejected

Hello,

Foreman try to remove puppet from its core to act in a more generic way. Today Foreman's reporting has been rewritten to not use Puppet.
This ticket is not valid anymore.

Regards,

Benjamin Papillon

Also available in: Atom PDF