Project

General

Profile

Actions

Feature #5240

closed

Expose eager-zeroing for vSphere volumes

Added by Dominic Cleal over 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Compute resources - VMware
Target version:
Difficulty:
easy
Triaged:
Fixed in Releases:
Found in Releases:

Description

From https://github.com/theforeman/foreman/issues/1382

I quickly hacked app/views/compute_resources_vms/form/vmware/_volume.html.erb so the last lines are:

  <%= checkbox_f f, :thin, {
             :label => _("Thin provision"),
             :class => 'disable-unsupported'},
             "true",
             "false" %>
  <%= checkbox_f f, :eager_zero, {
             :label => "Eager zero",
             :class => 'disable-unsupported',
             :help_inline => remove_child_link("X", f, { :method => :'_delete', :title => _('remove volume'), :class => 'label label-danger disable-unsupported' })},
             "true",
             "false" %>
</div>

Hacked because I didn't bother with the label localization.
It doesn't work out of the box yet because of a bug in fog (https://github.com/fog/fog/issues/2857) but at least with both fixes my SAN admin is happy now :)

Sorry for not supplying a PR. Hope it's trivial enough for someone to do (properly).

Actions #1

Updated by Anonymous about 10 years ago

  • Category changed from Compute resources to Compute resources - VMware
  • Target version set to 1.7.4
  • Assignee set to Anonymous
Actions #2

Updated by The Foreman Bot about 10 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1708 added
  • Pull request deleted ()
Actions #3

Updated by Dominic Cleal about 10 years ago

  • Translation missing: en.field_release set to 10
Actions #4

Updated by Anonymous about 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF