Project

General

Profile

Feature #5368

Bastion: replace function declarations with function expressions

Added by Mike McCune about 8 years ago. Updated almost 4 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

From https://github.com/Katello/katello/pull/3805/files#r10587210

Best practices are to use function expressions instead of declarations. We are using function declarations as success and error callbacks mainly.

We should also document this in the readme file.

See also: http://javascriptweblog.wordpress.com/2010/07/06/function-declarations-vs-function-expressions/
----
Imported from https://trello.com/c/UFjU3xw4/382-bastion-replace-function-declarations-with-function-expressions_

History

#1 Updated by Eric Helms about 7 years ago

  • Status changed from New to Rejected
  • Triaged set to Yes

#2 Updated by Eric Helms almost 6 years ago

  • Legacy Backlogs Release (now unused) set to 166

Also available in: Atom PDF