Project

General

Profile

Actions

Refactor #6304

closed

Reconsider `apply_default_info` code

Added by Ivan Necas almost 10 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Branch:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

After making the V1 controllers obsolete, the code around applying default info to the organization got more or less unreachable

https://github.com/Katello/katello/blob/22db6d7770819282ef00d08cf74e36e0a13dc861/app/models/katello/concerns/organization_extensions.rb#L215-L231

Since it uses the delayed jobs for the async work, it should either be removed and rewritten to Dynflow or just removed (in case we don't plan to provide this functionality later)


Related issues 1 (0 open1 closed)

Blocks Katello - Refactor #6297: Remove katello-jobsClosedIvan Necas06/19/2014Actions
Actions #1

Updated by Ivan Necas almost 10 years ago

Actions #2

Updated by Eric Helms over 9 years ago

  • Target version changed from 49 to 54
Actions #3

Updated by Ivan Necas over 9 years ago

  • Status changed from New to Assigned

I went thought he code, ui and api and the code for applying the default info to hosts and as it is now, it's not reachable. Also, the foreman facts should probably be considered as replacement for the system custom info. As this one of the last async tasks using the delayed jobs, I'm removing the old code, and posponing the re-implementation (if any) to later stages.

Actions #4

Updated by Eric Helms over 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Assignee set to Ivan Necas
  • Triaged changed from No to Yes
  • Pull request https://github.com/Katello/katello/pull/4564 added
  • Pull request deleted ()
Actions #5

Updated by Eric Helms over 9 years ago

  • Target version changed from 54 to 55
Actions #6

Updated by Eric Helms over 9 years ago

  • translation missing: en.field_release set to 13
Actions #7

Updated by Ivan Necas over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF