Project

General

Profile

Refactor #6304

Reconsider `apply_default_info` code

Added by Ivan Necas about 5 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

After making the V1 controllers obsolete, the code around applying default info to the organization got more or less unreachable

https://github.com/Katello/katello/blob/22db6d7770819282ef00d08cf74e36e0a13dc861/app/models/katello/concerns/organization_extensions.rb#L215-L231

Since it uses the delayed jobs for the async work, it should either be removed and rewritten to Dynflow or just removed (in case we don't plan to provide this functionality later)


Related issues

Blocks Katello - Refactor #6297: Remove katello-jobsClosed2014-06-19

Associated revisions

Revision 29b2a618 (diff)
Added by Ivan Necas almost 5 years ago

Fixes #6304 - remove apply default info

As the feature is not reachable by the current UI/API and CLI and
there are no recent plans for enabling this feature again (probably
the foreman facts might be used instead), I'm removing the apply
default info to all hosts, as it's one of the last parts of the
code-base using delayed jobs and investing time to rewriting this to
Dynflow is not effective.

History

#1 Updated by Ivan Necas about 5 years ago

#2 Updated by Eric Helms almost 5 years ago

  • Target version changed from 49 to 54

#3 Updated by Ivan Necas almost 5 years ago

  • Status changed from New to Assigned

I went thought he code, ui and api and the code for applying the default info to hosts and as it is now, it's not reachable. Also, the foreman facts should probably be considered as replacement for the system custom info. As this one of the last async tasks using the delayed jobs, I'm removing the old code, and posponing the re-implementation (if any) to later stages.

#4 Updated by Eric Helms almost 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Assignee set to Ivan Necas
  • Triaged changed from No to Yes
  • Pull request https://github.com/Katello/katello/pull/4564 added
  • Pull request deleted ()

#5 Updated by Eric Helms almost 5 years ago

  • Target version changed from 54 to 55

#6 Updated by Eric Helms almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 13

#7 Updated by Ivan Necas almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF