Refactor #6304: Reconsider `apply_default_info` code - Katello - Foreman

Actions

Copy link

Refactor #6304

closed

Reconsider `apply_default_info` code

Added by Ivan Necas almost 11 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ivan Necas

Category:

Target version:

Katello 2.0

Branch:

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/Katello/katello/pull/4564

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

After making the V1 controllers obsolete, the code around applying default info to the organization got more or less unreachable

https://github.com/Katello/katello/blob/22db6d7770819282ef00d08cf74e36e0a13dc861/app/models/katello/concerns/organization_extensions.rb#L215-L231

Since it uses the delayed jobs for the async work, it should either be removed and rewritten to Dynflow or just removed (in case we don't plan to provide this functionality later)

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Ivan Necas over 10 years ago

Status changed from New to Assigned

I went thought he code, ui and api and the code for applying the default info to hosts and as it is now, it's not reachable. Also, the foreman facts should probably be considered as replacement for the system custom info. As this one of the last async tasks using the delayed jobs, I'm removing the old code, and posponing the re-implementation (if any) to later stages.