Project

General

Profile

Feature #6788

Add a puppet class filter to the scanner to filter puppet class imports based on directory or name

Added by Nils Domrose about 6 years ago. Updated over 5 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
Puppet
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Several puppet deployments follow the module, profile(aka service), role pattern. Using this pattern, only roles will be applied to servers so all other puppet modules are irrelevant from foreman perspective. Such a feature can dramatically decrease the amount of time it takes to scan unnecessary modules wich multiplies by the amount of environments.

Proposal:
Add two additional settings to the smart_proxy:

:puppet_ignore_modulefolder:
- services
- modules

This one prevents scanning of listed directories in your module path

and
:puppet_include_modules: "role_*"

This one only includes modules with a specific name
Both settings are completely optional, the first supports multi-module dir struktures while the latter supports flat structures, too while it would also work with multi module dir structures.

History

#2 Updated by Nils Domrose about 6 years ago

The patch speeded up imports on our puppet env from 7+ minutes to about 10 seconds due to the amount of environments and modules.

#3 Updated by Dominic Cleal about 6 years ago

  • Category set to Puppet
  • Status changed from New to Ready For Testing
  • Assignee set to Nils Domrose
  • Target version set to 1.8.0
  • Pull request https://github.com/theforeman/smart-proxy/pull/191 added
  • Pull request deleted ()

#4 Updated by Dmitri Dolguikh about 6 years ago

  • Target version changed from 1.8.0 to 1.7.5

#5 Updated by Dmitri Dolguikh almost 6 years ago

  • Target version changed from 1.7.5 to 1.7.4

#6 Updated by Dmitri Dolguikh almost 6 years ago

  • Target version changed from 1.7.4 to 1.7.3

#7 Updated by Dominic Cleal almost 6 years ago

  • Target version changed from 1.7.3 to 1.7.2

#8 Updated by Nils Domrose over 5 years ago

I closed pull https://github.com/theforeman/smart-proxy/pull/191 in favor of the scanner cache implementation introduced by #8210 so I guess this can be closed, too.

#9 Updated by Dominic Cleal over 5 years ago

  • Status changed from Ready For Testing to Rejected
  • Target version deleted (1.7.2)

Also available in: Atom PDF