Project

General

Profile

Bug #7920

Foreman should never block init, also not when daemon=false

Added by Eric Feliksik over 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Debian/Ubuntu
Target version:
1.12.1
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman-packaging/pull/1171
Fixed in Releases:
Found in Releases:
Foreman - 1.6.1

Description

  1. by default smart-proxy runs in the foreground. To enable running as a daemon, uncomment 'daemon' setting
    #:daemon true

If you do /not/ have ':daemon true', the foreman-proxy debian packages blocks init on bootup!
I do not think this is desired behavior (?)

Associated revisions

Revision f5bf6c2a (diff)
Added by Michael Moll over 4 years ago

fixes #7920 - redo check if proxy is enabled

History

#1 Updated by Dominic Cleal over 6 years ago

  • Project changed from Foreman to Packaging
  • Category set to Debian/Ubuntu

I think the smart proxy behaviour changed subtly between 1.5 and 1.6, so now if it's not specified, it implies true, while it used to possibly imply false.

This check should probably be updated to look for daemon\s*true:

https://github.com/theforeman/foreman-packaging/blob/deb/develop/debian/wheezy/foreman-proxy/init.d#L53-L56

#2 Updated by The Foreman Bot over 4 years ago

  • Assignee set to Anonymous
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-packaging/pull/1171 added

#3 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) set to 161

#4 Updated by Anonymous over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF