Bug #8377
closedNic::Base.uniq_with_hosts fails if host is nil
Description
In the staypuft plugin, we've added a VipNic subclass of Nic::Managed to manage virtual IPs for a deployment. In this class, we've overridden require_host? to return 'false' since these will not be associated with a particular host.
The one thing that isn't working for us here is that the uniq_with_hosts validation fails since it's calling host.mac. I will submit a PR which adds a check to see if the host reference is set. If the host is nil, the result is the same as if the host's value is not in conflict -- the validation continues to the elsif in the loop to determine if the value is already in use on another host.
Updated by The Foreman Bot almost 10 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/1928 added
- Pull request deleted (
)
Updated by Scott Seago almost 10 years ago
PR is here: https://github.com/theforeman/foreman/pull/1928
Updated by Marek Hulán almost 10 years ago
- Category set to Network
- Assignee set to Scott Seago
- Translation missing: en.field_release set to 28
Updated by Scott Seago almost 10 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset a95495bfd129103df0b08b1c1d71efc6af53fca5.