Project

General

Profile

Bug #9084

net-ldap 0.11 throwing uncaught exceptions with invalid filters

Added by Dominic Cleal over 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Urgent
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Some tests are failing since net-ldap 0.11:

Invalid filter syntax. (Net::LDAP::FilterSyntaxInvalidError)
/usr/local/rvm/gems/ruby-1.9.3-p392@test_develop_pr_core-1/gems/net-ldap-0.11/lib/net/ldap/filter.rb:674:in `initialize'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_develop_pr_core-1/gems/net-ldap-0.11/lib/net/ldap/filter.rb:667:in `new'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_develop_pr_core-1/gems/net-ldap-0.11/lib/net/ldap/filter.rb:667:in `parse'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_develop_pr_core-1/gems/net-ldap-0.11/lib/net/ldap/filter.rb:341:in `construct'
/var/lib/workspace/workspace/test_develop_pr_core/database/sqlite3/ruby/1.9.3/app/models/auth_sources/auth_source_ldap.rb:165:in `validate_ldap_filter'
...
/var/lib/workspace/workspace/test_develop_pr_core/database/sqlite3/ruby/1.9.3/test/unit/auth_source_ldap_test.rb:107:in `block in <class:AuthSourceLdapTest>'

AuthSourceLdapTest.test_0010_the ldap_filter should not exceed the 255 characters
AuthSourceLdapTest.test_0016_invalid ldap_filter fails validation

http://ci.theforeman.org/job/test_develop/1099/

Associated revisions

Revision c8652830 (diff)
Added by Dominic Cleal over 4 years ago

fixes #9084 - catch net-ldap 0.11's specific invalid filter exception

Revision 22e8d091 (diff)
Added by Dominic Cleal over 4 years ago

fixes #9084 - catch net-ldap 0.11's specific invalid filter exception

(cherry picked from commit c86528305233a1acf51f4bae8678cd7b182d2a16)

Conflicts:
app/models/auth_sources/auth_source_ldap.rb

History

#1 Updated by Dominic Cleal over 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Dominic Cleal

#2 Updated by The Foreman Bot over 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2103 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) set to 30

#4 Updated by Dominic Cleal over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF