Project

General

Profile

Actions

Bug #9708

closed

Fix our rubocop file to override houndci's configuration

Added by David Davis over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:
Actions #1

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-docker/pull/96 added
  • Pull request deleted ()
Actions #2

Updated by David Davis over 9 years ago

  • Status changed from Ready For Testing to Closed
  • Pull request added
  • Pull request deleted (https://github.com/theforeman/foreman-docker/pull/96)
Actions #3

Updated by The Foreman Bot over 9 years ago

  • Pull request https://github.com/theforeman/foreman-docker/pull/96 added
  • Pull request deleted ()
Actions #4

Updated by David Davis over 9 years ago

It looks like houndci is overriding our setting for DotPosition so it needs to be set. Also, I'm turning on MethodCalledOnDoEndBlock which we've enabled for other projects. Here's a test case. Add it to any model.

def test_method
  User.where(:name => "jfkdlsjfdslkfjsldf dsfjkldsf jskl fjsdlkf sjlfkdsj fklsdfj jdslkfds")
    .first
end
Actions #5

Updated by David Davis over 9 years ago

  • Subject changed from Fix hound ci configuration to use our rubocop file to Fix our rubocop file to override houndci's configuration
Actions #6

Updated by David Davis over 9 years ago

  • Pull request https://github.com/theforeman/foreman-docker/pull/97 added
  • Pull request deleted (https://github.com/theforeman/foreman-docker/pull/96)
Actions

Also available in: Atom PDF