Project

General

Profile

Bug #9708

Fix our rubocop file to override houndci's configuration

Added by David Davis over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Associated revisions

Revision 13ae4ad1 (diff)
Added by David Davis over 7 years ago

Fixes #9708 - Fixing rubocop config so it can be used with houndci

Revision 129c20bf
Added by David Davis over 7 years ago

Merge pull request #97 from daviddavis/temp/20150310153421

Fixes #9708 - Fixing rubocop config so it can be used with houndci

Revision 4282fa50 (diff)
Added by David Davis over 7 years ago

Fixes #9708 - Fixing rubocop config so it can be used with houndci

Revision 4282fa50 (diff)
Added by David Davis over 7 years ago

Fixes #9708 - Fixing rubocop config so it can be used with houndci

History

#1 Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-docker/pull/96 added
  • Pull request deleted ()

#2 Updated by David Davis over 7 years ago

  • Status changed from Ready For Testing to Closed
  • Pull request added
  • Pull request deleted (https://github.com/theforeman/foreman-docker/pull/96)

#3 Updated by The Foreman Bot over 7 years ago

  • Pull request https://github.com/theforeman/foreman-docker/pull/96 added
  • Pull request deleted ()

#4 Updated by David Davis over 7 years ago

It looks like houndci is overriding our setting for DotPosition so it needs to be set. Also, I'm turning on MethodCalledOnDoEndBlock which we've enabled for other projects. Here's a test case. Add it to any model.

def test_method
  User.where(:name => "jfkdlsjfdslkfjsldf dsfjkldsf jskl fjsdlkf sjlfkdsj fklsdfj jdslkfds")
    .first
end

#5 Updated by David Davis over 7 years ago

  • Subject changed from Fix hound ci configuration to use our rubocop file to Fix our rubocop file to override houndci's configuration

#6 Updated by David Davis over 7 years ago

  • Pull request https://github.com/theforeman/foreman-docker/pull/97 added
  • Pull request deleted (https://github.com/theforeman/foreman-docker/pull/96)

Also available in: Atom PDF