Project

General

Profile

Actions
Copy link

Bug #9708

closed

Fix our rubocop file to override houndci's configuration

Added by David Davis about 10 years ago. Updated about 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
David Davis
Category:
-
Target version:
-
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman-docker/pull/97
Fixed in Releases:
Found in Releases:
Red Hat JIRA:
Actions
Copy link
 #1

Updated by The Foreman Bot about 10 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-docker/pull/96 added
  • Pull request deleted ()
Actions
Copy link
 #2

Updated by David Davis about 10 years ago

  • Status changed from Ready For Testing to Closed
  • Pull request added
  • Pull request deleted (https://github.com/theforeman/foreman-docker/pull/96)
Actions
Copy link
 #3

Updated by The Foreman Bot about 10 years ago

  • Pull request https://github.com/theforeman/foreman-docker/pull/96 added
  • Pull request deleted ()
Actions
Copy link
 #4

Updated by David Davis about 10 years ago

It looks like houndci is overriding our setting for DotPosition so it needs to be set. Also, I'm turning on MethodCalledOnDoEndBlock which we've enabled for other projects. Here's a test case. Add it to any model.

def test_method
  User.where(:name => "jfkdlsjfdslkfjsldf dsfjkldsf jskl fjsdlkf sjlfkdsj fklsdfj jdslkfds")
    .first
end
Actions
Copy link
 #5

Updated by David Davis about 10 years ago

  • Subject changed from Fix hound ci configuration to use our rubocop file to Fix our rubocop file to override houndci's configuration
Actions
Copy link
 #6

Updated by David Davis about 10 years ago

  • Pull request https://github.com/theforeman/foreman-docker/pull/97 added
  • Pull request deleted (https://github.com/theforeman/foreman-docker/pull/96)
Actions
Copy link

Also available in: Atom PDF