Feature #10982

Add logging to smart proxy requests (ProxyAPI)

Added by Dominic Cleal over 2 years ago. Updated 6 months ago.

Status:Closed
Priority:Normal
Assigned To:Dominic Cleal
Category:Logging
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/3683, https://github.com/theforeman/foreman/pull/4702
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

We should add a new logger for debugging smart proxy traffic and requests going via ProxyAPI.

Perhaps inside ProxyAPI classes themselves, or something like RestClient.log (so long as it doesn't duplicate compute resource logging, e.g. with oVirt).


Related issues

Related to Smart Proxy - Feature #15874: Log X-Request-ID by default Closed 07/28/2016
Related to Foreman - Feature #15863: Log request IDs (tagged logging) in production.log Closed 07/27/2016
Related to Plugins - Bug #20457: foreman_memcache is not compatible with 1.16 New 07/31/2017
Duplicated by Foreman - Feature #15876: Send request and session ids to foreman-proxy as HTTP hea... Duplicate 07/28/2016

Associated revisions

Revision 972adab0
Added by Dominic Cleal 6 months ago

fixes #10982 - configure RestClient log to 'proxy' logger

Request/response information is sent to the proxy logger, showing the
URLs called, headers, request body etc.

The X-Request-ID header is now also set in the proxy requests to a
random ID stored in the session, to prevent the user's real session ID
being hijacked from the proxy request data. The ID should be correlated
against the proxy logger.

History

#1 Updated by Dominic Cleal over 1 year ago

  • Status changed from New to Assigned
  • Assigned To set to Dominic Cleal

#2 Updated by Dominic Cleal over 1 year ago

#3 Updated by The Foreman Bot over 1 year ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3683 added

#4 Updated by Dominic Cleal over 1 year ago

  • Related to Feature #15863: Log request IDs (tagged logging) in production.log added

#5 Updated by Dominic Cleal over 1 year ago

  • Duplicated by Feature #15876: Send request and session ids to foreman-proxy as HTTP headers added

#6 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/foreman/pull/4702 added

#7 Updated by Daniel Lobato Garcia 6 months ago

  • Release set to 1.16.0

#8 Updated by Dominic Cleal 6 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by Ohad Levy 6 months ago

  • Related to Bug #20457: foreman_memcache is not compatible with 1.16 added

Also available in: Atom PDF