Project

General

Profile

Actions

Bug #16378

closed

check_override_selected checks changes not performed by user

Added by Ori Rabin over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Parameters
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

check_override_selected is run before validations when saving a smart class parameters.
Actions that are called before validation like cast_default_value can add changed attributes that are later checked and can cause a validation message.

Steps:
1) Import puppetclass with a boolean smart class parameter with the value 't' or 'f'
2) Edit the puppetclass and click save (without any changes)

The result should be that it saves since no changes were made.
Actual result: "override must be true to edit the parameter"

This is because when saving the default value is casted and changed to 'true'.
check_override_selected catches that change as something that is not allowed unless override is true.

Actions #1

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3804 added
Actions #2

Updated by Ivan Necas over 7 years ago

  • Target version set to 127
Actions #3

Updated by Ori Rabin over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal over 7 years ago

  • Category set to Parameters
  • translation missing: en.field_release set to 190
Actions

Also available in: Atom PDF