Bug #16378
closedcheck_override_selected checks changes not performed by user
Description
check_override_selected is run before validations when saving a smart class parameters.
Actions that are called before validation like cast_default_value can add changed attributes that are later checked and can cause a validation message.
Steps:
1) Import puppetclass with a boolean smart class parameter with the value 't' or 'f'
2) Edit the puppetclass and click save (without any changes)
The result should be that it saves since no changes were made.
Actual result: "override must be true to edit the parameter"
This is because when saving the default value is casted and changed to 'true'.
check_override_selected catches that change as something that is not allowed unless override is true.
Updated by The Foreman Bot about 8 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3804 added
Updated by Ori Rabin about 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 1ebc15ea40ebc4eaddc7afb8e83753841a724b1d.
Updated by Dominic Cleal about 8 years ago
- Category set to Parameters
- Translation missing: en.field_release set to 190