Bug #18952

Notifications issues prevent host to be destroyed

Added by Ivan Necas 6 days ago. Updated 5 days ago.

Status:Closed
Priority:Normal
Assigned To:Ivan Necas
Category:Notifications
Target version:Team Ivan Iteration 12
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4302, https://github.com/theforeman/foreman/pull/4387
Story points-
Velocity based estimate-

Description

When a host doesn't have an owner set (it happened to me, when I created fake host via console,
the failure to send notification prevented the host to be destroyed and no useful message was provided:
everything seemed fine, except the host was still there.

I believe the failures in notifications should not influence the functionality of the operation itself.

2017-03-17T17:41:04 e59c76c5  [app] [D] Setting current user thread-local variable to admin
2017-03-17T17:41:04 e59c76c5 [user:admin] [app] [D] Setting current organization thread-local variable to none
2017-03-17T17:41:04 e59c76c5 [user:admin] [app] [D] Setting current location thread-local variable to none
2017-03-17T17:41:04 e59c76c5 [user:admin] [notifications] [W] Invalid owner for aaron-brangers, unable to send notifications
2017-03-17T17:41:04 e59c76c5 [user:admin] [notifications] [D] Notification event: Hosts::MissingOwner - checking for notifications
2017-03-17T17:41:04 e59c76c5 [user:admin] [app] [I] Failed to save:
2017-03-17T17:41:04 e59c76c5 [user:admin] [app] [I] Redirected to http://localhost:3000/hosts

Associated revisions

Revision 54db95ae
Added by Ivan Necas 5 days ago

Fixes #18952 - fix destroy of host without owner

The notifications failure caused the host not being deleted.
I don't think the notifications should interfere with the core
functionality of the objects.

History

#1 Updated by The Foreman Bot 6 days ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4387 added

#2 Updated by Ivan Necas 5 days ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by The Foreman Bot 5 days ago

  • Pull request https://github.com/theforeman/foreman/pull/4302 added

Also available in: Atom PDF